refactor(jest-jasmine2, jest-runtime): use Symbol to pass jest.setTimeout
value instead of jasmine
specific logic
#12124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
jest-runtime
still implementsjasmine
specific logic forjest.setTimeout
function. It seems like simple refactor is enough to be able to useSymbol.for('TEST_TIMEOUT_SYMBOL')
for both test runners (currently it is used only byjest-circus
).Benefits of this change:
jest-runtime
would have nojasmine
specific code; hence, this would make possible to get rid ofjasmine
specific types as well. I have a draft for types too, but left it for separate PR.There is no need of a change log entry in this case, right?
By the way, an alternative solution can be seen in the first commit. In this case
jasmine
s private_DEFAULT_TIMEOUT_INTERVAL
is replaced byglobal[testTimeoutSymbol]
everywhere. All worked, but seemed more invasive and perhaps breaking too.Test plan
The existing test suite should be sufficient.